From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: dw-hdmi-qp: Add HDMI 2.0 SCDC scrambling support` Date: Mon, 25 May 2026 21:15:05 +1000 Message-ID: In-Reply-To: <20260520-dw-hdmi-qp-scramb-v6-13-24b74603b782@collabora.com> References: <20260520-dw-hdmi-qp-scramb-v6-0-24b74603b782@collabora.com> <20260520-dw-hdmi-qp-scramb-v6-13-24b74603b782@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This is the main driver-level implementation patch. 1. **`curr_conn` lifetime**: The `curr_conn` pointer is set in `atomic_enab= le` and cleared in `atomic_disable`. It is used in `dw_hdmi_qp_hpd_notify()= ` (patch 14) to decide which HPD notification path to take. There's a poten= tial race if an HPD interrupt fires during `atomic_disable` after `curr_con= n` is set to NULL but before the PHY is disabled. However, the HPD interrup= t handler only schedules deferred work, so by the time the work runs, the s= tate should be consistent. 2. **Scrambling before PHY init**: In `atomic_enable`, `drm_scdc_start_scra= mbling()` is called *before* `hdmi->phy.ops->init()`. This sets up the sink= -side SCDC configuration and source-side scrambling before the PHY is initi= alized. The HDMI 2.0 spec requires TMDS clock to be suspended while changin= g clock ratio, so starting scrambling before PHY init (while clock is still= off) is correct. 3. **Error path in atomic_enable**: If `drm_scdc_start_scrambling()` fails,= a warning is logged but the enable continues. This is reasonable =E2=80=94= you'd rather attempt to display something than fail silently. 4. **HDMI20_MAX_TMDSRATE =3D 600MHz**: This correctly caps the TMDS rate at= the HDMI 2.0 maximum (600 MHz), above which HDMI 2.1 FRL would be needed. 5. **Copyright addition**: Amazon copyright is added alongside Collabora an= d Rockchip. This appears legitimate given the contribution. --- Generated by Claude Code Patch Reviewer