From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dpu: use new helper to set ubwc_swizzle Date: Mon, 25 May 2026 21:41:59 +1000 Message-ID: In-Reply-To: <20260520-ubwc-rework-v5-13-72f2749bc807@oss.qualcomm.com> References: <20260520-ubwc-rework-v5-0-72f2749bc807@oss.qualcomm.com> <20260520-ubwc-rework-v5-13-72f2749bc807@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review DPU SSPP migration. Replaces `ctx->ubwc->ubwc_swizzle` with `qcom_ubwc_swizzle(ctx->ubwc)` and switches from raw `& 0x1` to the symbolic `& UBWC_SWIZZLE_ENABLE_LVL1`. ```c - ctrl_val = fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | + ctrl_val = fast_clear | + (qcom_ubwc_swizzle(ctx->ubwc) & UBWC_SWIZZLE_ENABLE_LVL1) | ``` Good cleanup replacing the magic `0x1` with the named constant. --- Generated by Claude Code Patch Reviewer