From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: panel-lvds: Add dual-channel LVDS support Date: Mon, 25 May 2026 19:56:40 +1000 Message-ID: In-Reply-To: <20260521150038.103538-30-ivitro@gmail.com> References: <20260521150038.103538-17-ivitro@gmail.com> <20260521150038.103538-30-ivitro@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This is the most significant binding change. It modifies the `required:` se= ction: ```yaml - - port + +oneOf: + - required: + - port + - required: + - ports + +if: + required: + - ports +then: + $ref: /schemas/display/lvds-dual-ports.yaml# ``` This is architecturally correct =E2=80=94 panels should support either sing= le `port` or dual `ports`. The `if/then` conditional reference to `lvds-dua= l-ports.yaml` is the right mechanism. **Ordering concern**: This patch (13/15) adds the dual-channel support, but= Patch 15 already depends on it. The series ordering has these at 13 and 15= , which is correct for application order. However, this binding patch shoul= d ideally come before any DTS that uses `ports` (Patch 15 is the only one),= so the ordering is fine. --- Generated by Claude Code Patch Reviewer