From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Remove bridge disabing and panel unpreparing in analogix_dp_unbind() Date: Wed, 11 Feb 2026 16:37:18 +1000 Message-ID: In-Reply-To: <20260210091024.2732369-1-damon.ding@rock-chips.com> References: <20260210071225.2566099-1-damon.ding@rock-chips.com> <20260210091024.2732369-1-damon.ding@rock-chips.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Patch Review **Summary:** Makes unbind() symmetric with bind(). ```c void analogix_dp_unbind(struct analogix_dp_device *dp) { - analogix_dp_bridge_disable(&dp->bridge); - - drm_panel_unprepare(dp->plat_data->panel); - drm_dp_aux_unregister(&dp->aux); } ``` **Review:** - Correct - bind() doesn't enable/prepare, so unbind() shouldn't disable/unprepare - DRM core handles bridge lifecycle through atomic helpers - Panel lifecycle is managed through panel_bridge **Verdict:** Approved, correct lifecycle management. --- --- Generated by Claude Code Patch Reviewer