From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: panel-orientation-quirks: Add OneXPlayer X1 Air
Date: Tue, 17 Feb 2026 07:19:43 +1000 [thread overview]
Message-ID: <review-patch14-20260216204547.293291-15-lkml@antheas.dev> (raw)
In-Reply-To: <20260216204547.293291-15-lkml@antheas.dev>
Patch Review
> + }, { /* OneXPlayer X1 Intel */
> + .matches = {
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1Air"),
> + },
> + .driver_data = (void *)&lcd1600x2560_leftside_up,
The comment says "OneXPlayer X1 Intel" but the commit subject says "Add OneXPlayer X1 Air" and the DMI product name is "ONEXPLAYER X1Air". The commit message says "Special edition of the X1 with a new Intel chipset." The comment should say "OneXPlayer X1 Air" (or "OneXPlayer X1Air") to match the actual product name, not just "X1 Intel" -- there is already a separate "X1 Intel" entry from patch 4 that matches "ONEXPLAYER X1 i". Using the same comment text for two different devices would be confusing.
Additionally, this patch inserts the X1Air entry between "X1 mini" and "X1 mini pro", which is an odd position. It might make more sense next to the other X1 entries (X1 A, X1 i, X1Pro, X1Pro EVA-02).
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-16 21:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 20:45 [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks Antheas Kapenekakis
2026-02-16 20:45 ` [PATCH v2 01/14] drm: panel-orientation-quirks: Add AOKZOE A1 Pro Antheas Kapenekakis
2026-02-16 21:19 ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 02/14] drm: panel-orientation-quirks: Add additional ID for Ayaneo 2021 Antheas Kapenekakis
2026-02-16 21:19 ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 03/14] drm: panel-orientation-quirks: Add Ayaneo 3 Antheas Kapenekakis
2026-02-16 21:19 ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 04/14] drm: panel-orientation-quirks: Add OneXPlayer X1 variants Antheas Kapenekakis
2026-02-16 21:19 ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 05/14] drm: panel-orientation-quirks: Add OneXPlayer X1 Mini variants Antheas Kapenekakis
2026-02-16 21:19 ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 06/14] drm: panel-orientation-quirks: Add OneXPlayer F1 variants Antheas Kapenekakis
2026-02-16 21:19 ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 07/14] drm: panel-orientation-quirks: Add OneXPlayer G1 variants Antheas Kapenekakis
2026-02-16 21:19 ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 08/14] drm: panel-orientation-quirks: Add GPD Win Max (2021) Antheas Kapenekakis
2026-02-16 21:19 ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 09/14] drm: panel-orientation-quirks: Add GPD Pocket 4 Antheas Kapenekakis
2026-02-16 21:19 ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 10/14] drm: panel-orientation-quirks: Add Zeenix Lite and Pro Antheas Kapenekakis
2026-02-16 21:19 ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 11/14] drm: panel-orientation-quirks: add SuiPlay0X1 Antheas Kapenekakis
2026-02-16 21:19 ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 12/14] drm: panel-orientation-quirks: Add OneXPlayer X1z Antheas Kapenekakis
2026-02-16 21:19 ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 13/14] drm: panel-orientation-quirks: Add AOKZOE A2 Pro Antheas Kapenekakis
2026-02-16 21:19 ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 14/14] drm: panel-orientation-quirks: Add OneXPlayer X1 Air Antheas Kapenekakis
2026-02-16 21:19 ` Claude Code Review Bot [this message]
2026-02-16 21:19 ` Claude review: drm: panel-orientation-quirks: Add various handheld quirks Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch14-20260216204547.293291-15-lkml@antheas.dev \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox