From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: panel-orientation-quirks: Add OneXPlayer X1 Air Date: Tue, 17 Feb 2026 07:19:43 +1000 Message-ID: In-Reply-To: <20260216204547.293291-15-lkml@antheas.dev> References: <20260216204547.293291-1-lkml@antheas.dev> <20260216204547.293291-15-lkml@antheas.dev> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review > + }, { /* OneXPlayer X1 Intel */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1Air"), > + }, > + .driver_data = (void *)&lcd1600x2560_leftside_up, The comment says "OneXPlayer X1 Intel" but the commit subject says "Add OneXPlayer X1 Air" and the DMI product name is "ONEXPLAYER X1Air". The commit message says "Special edition of the X1 with a new Intel chipset." The comment should say "OneXPlayer X1 Air" (or "OneXPlayer X1Air") to match the actual product name, not just "X1 Intel" -- there is already a separate "X1 Intel" entry from patch 4 that matches "ONEXPLAYER X1 i". Using the same comment text for two different devices would be confusing. Additionally, this patch inserts the X1Air entry between "X1 mini" and "X1 mini pro", which is an odd position. It might make more sense next to the other X1 entries (X1 A, X1 i, X1Pro, X1Pro EVA-02). --- Generated by Claude Code Patch Reviewer