From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: ARM: dts: imx6ul-var-som: add support for LVDS display panel Date: Tue, 03 Mar 2026 12:58:08 +1000 Message-ID: In-Reply-To: <20260302190953.669325-15-hugo@hugovil.com> References: <20260302190953.669325-1-hugo@hugovil.com> <20260302190953.669325-15-hugo@hugovil.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Issue 1**: The `lvds_panel` node is defined in `imx6ul-var-som-concerto-c= ommon.dtsi`, meaning every concerto board (even without LVDS) gets this pan= el node with timings. It would be cleaner to define the entire panel in `im= x6ul-var-som-lvds-panel.dtsi`. **Issue 2**: The panel node lacks a `backlight =3D <&lcd_backlight>;` prope= rty. Without it, the backlight won't be automatically controlled by the DRM= panel subsystem. **Issue 3**: The `pwm-names` property is unusual: ``` pwm-names =3D "LCD_BKLT_PWM"; ``` The `pwm-backlight` driver doesn't use `pwm-names` and this value serves no= purpose. Either drop it or use the conventional lowercase naming. **Issue 4**: `status =3D "okay"` on the backlight node is redundant for a r= oot-level node. **Issue 5**: The commit message has a typo =E2=80=94 missing space: "option= so" should be "option, so". **Issue 6**: The `lcdif_dat` pinctrl only configures 18 data pins (skipping= DATA00-01, DATA08-09, DATA16-17), consistent with JEIDA-18 mapping. This l= ooks intentional for the 18-bit LVDS encoder, which is correct. --- Generated by Claude Code Patch Reviewer