From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: firmware: qcom_scm: Remove SCM PAS wrappers Date: Mon, 09 Mar 2026 08:59:10 +1000 Message-ID: In-Reply-To: <20260306105027.290375-15-sumit.garg@kernel.org> References: <20260306105027.290375-1-sumit.garg@kernel.org> <20260306105027.290375-15-sumit.garg@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Clean removal of all the transitional wrapper functions and their declarati= ons from `qcom_scm.h`. The `qcom_scm_set_remote_state` declaration and impl= ementation are also correctly removed (it was moved to the PAS layer in pat= ch 3). The internal `__qcom_scm_pas_*` functions are kept as they're now us= ed as ops callbacks registered in `qcom_pas_ops_scm`. One concern: `qcom_scm_is_available()` is NOT removed =E2=80=94 only the PA= S-specific functions are. Client drivers that were using `qcom_scm_is_avail= able()` for PAS readiness now use `qcom_pas_is_available()`. But `qcom_scm_= is_available()` is still used by other callers for non-PAS SCM functionalit= y, which is correct. --- Generated by Claude Code Patch Reviewer