From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge_connector: Convert to atomic_create_state Date: Wed, 11 Mar 2026 13:09:09 +1000 Message-ID: In-Reply-To: <20260310-drm-mode-config-init-v1-14-de7397c8e1cf@kernel.org> References: <20260310-drm-mode-config-init-v1-0-de7397c8e1cf@kernel.org> <20260310-drm-mode-config-init-v1-14-de7397c8e1cf@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean conversion. The bridge connector's reset only initialized a pristine state (plus HDMI-specific initialization), so the conversion is straightforward. The HDMI-specific reset is properly chained after the base state creation. --- **Summary of issues to address:** 1. **Bug (Patch 8):** `drm_connector_list_iter_end()` not called on error return from the connector loop in `drm_mode_config_create_state()`. 2. **Potential crash (Patch 10):** `drm_atomic_private_obj_fini()` will pass NULL to `atomic_destroy_state()` if called before `drm_dev_register()` (error path during probe). 3. **No rollback on partial failure (Patch 8):** `drm_mode_config_create_state()` leaks already-allocated states if a later allocation fails. 4. **Side effect in create_state helpers (Patches 5-7):** The `__drm_atomic_helper_*_create_state()` functions call `__drm_atomic_helper_*_reset()` which sets the object's state pointer, contradicting the "no side effect" principle. Consider using `__drm_atomic_helper_*_state_reset()` instead. 5. **Minor (Patches 5-7):** Repeated "software tate" typo in commit messages. 6. **Minor (Patch 3):** `@drm_private_obj` should be `&drm_private_obj` in kerneldoc. --- Generated by Claude Code Patch Reviewer