From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/display: Add helper for AS SDP transmission time selection Date: Tue, 31 Mar 2026 17:39:48 +1000 Message-ID: In-Reply-To: <20260330040656.4116502-15-ankit.k.nautiyal@intel.com> References: <20260330040656.4116502-1-ankit.k.nautiyal@intel.com> <20260330040656.4116502-15-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The helper `intel_dp_as_sdp_transmission_time()` takes no arguments and alw= ays returns `DP_PR_AS_SDP_SETUP_TIME_T1` (which is `(0 << 6)` =3D 0). This = is a bit over-engineered for a constant zero return, but it documents the i= ntent and makes future changes easier. The `get_pr_alpm_as_sdp_transmission_time()` function in intel_alpm.c takes= a `crtc_state` parameter but doesn't use it =E2=80=94 the called function = takes no arguments. Minor dead parameter. No R-b tag. **Nit:** `#include "intel_display_utils.h"` is added in intel_alpm.c but it= 's unclear this header is needed =E2=80=94 `MISSING_CASE` likely comes from= another header already included. --- Generated by Claude Code Patch Reviewer