From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: jadard-jd9365da-h3: support Waveshare round DSI panels Date: Sun, 12 Apr 2026 09:06:56 +1000 Message-ID: In-Reply-To: <20260411-waveshare-dsi-touch-v2-14-75cdbeac5156@oss.qualcomm.com> References: <20260411-waveshare-dsi-touch-v2-0-75cdbeac5156@oss.qualcomm.com> <20260411-waveshare-dsi-touch-v2-14-75cdbeac5156@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds Waveshare 3.4" (800x800) and 4.0" (720x720) round panels. **Significant code duplication**: `waveshare_3_4_c_init()` and `waveshare_4_0_c_init()` are ~200 lines each and nearly identical. The only difference appears to be a single register value (register `0x40` on page `0x01`: `0x00` vs `0x04`). These should be consolidated into a shared helper with a parameter for the differing value. --- --- Generated by Claude Code Patch Reviewer