From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: ti: k3-am62p-j722s-common-main: Add support for DSS Date: Thu, 23 Apr 2026 09:46:00 +1000 Message-ID: In-Reply-To: <20260420-beagley-ai-display-v1-14-f628543dfd14@ideasonboard.com> References: <20260420-beagley-ai-display-v1-0-f628543dfd14@ideasonboard.com> <20260420-beagley-ai-display-v1-14-f628543dfd14@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Large DTS patch with comprehensive DSS0, DSS1, OLDI, DPHY, and DSI node definitions. The fixed-factor-clock dividers for OLDI (`dss0_vp1_clk`, `dss1_vp1_clk`) with `/7` ratio are correct for OLDI (7:1 serialization). The OLDI nodes properly include `power-domains` for the AM62P OLDI power domains. The `dss0_oldi1` node for the secondary OLDI correctly omits `clocks` and `ti,oldi-io-ctrl` since those are only needed by the primary. Both `dss0` and `dss1` have `status = "disabled"`, requiring board-level enablement. Good. The duplicate `oldi@1` nodes (in both DSS0 and DSS1) representing the shared OLDI1 hardware are as described in the cover letter. Both reference the same `power-domains = <&k3_pds 244 ...>`. The commit message thoroughly documents why this is necessary. No issues. --- Generated by Claude Code Patch Reviewer