From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: wifi: ath12k: Switch to generic PAS TZ APIs Date: Tue, 05 May 2026 08:22:46 +1000 Message-ID: In-Reply-To: <20260504130603.1474043-15-sumit.garg@kernel.org> References: <20260504130603.1474043-1-sumit.garg@kernel.org> <20260504130603.1474043-15-sumit.garg@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **BUG: printf format string mismatch:** ```c - ath12k_err(ab, "scm pas shutdown failed for userPD%d\n", + ath12k_err(ab, "pas shutdown failed for userPD%d: %d\n", ab_ahb->userpd_id); ``` The new format string has two `%d` specifiers but only one argument (`ab_ahb->userpd_id`) is provided. The missing `ret` argument will cause stack garbage to be printed, or potentially undefined behavior depending on architecture. This **must** be fixed by adding `ret` as the second argument: ```c ath12k_err(ab, "pas shutdown failed for userPD%d: %d\n", ab_ahb->userpd_id, ret); ``` The Kconfig change from `select QCOM_SCM` to `select QCOM_PAS` is correct. --- --- Generated by Claude Code Patch Reviewer