From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Rework HDP and RXSENSE interrupt handling Date: Tue, 05 May 2026 07:58:57 +1000 Message-ID: In-Reply-To: <20260504191059.275928-15-jonas@kwiboo.se> References: <20260504191059.275928-1-jonas@kwiboo.se> <20260504191059.275928-15-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This is the largest and most impactful patch. It removes all RXSENSE handli= ng, simplifies the IRQ handler to only care about HPD, and removes the `for= ce`, `disabled`, `rxsense`, and `phy_mask` fields from `struct dw_hdmi`. The simplified `dw_hdmi_phy_setup_hpd()` now sets HPD polarity based on cur= rent status: ```c + hdmi_modb(hdmi, hdmi_readb(hdmi, HDMI_PHY_STAT0) & HDMI_PHY_HPD ? + 0 : HDMI_PHY_HPD, HDMI_PHY_HPD, HDMI_PHY_POL0); ``` This avoids a spurious interrupt at probe/resume when a sink is already con= nected =E2=80=94 the polarity is set to trigger only on the *next* change. The `dw_hdmi_phy_update_hpd()` is emptied here (removed in patch 16). The `= dw_hdmi_setup_rx_sense()` is also emptied (removed in patch 15). This two-s= tep approach (empty then remove) is clean for bisection since external call= ers (meson, rockchip, sun4i, imx) need their references removed separately. **Concern about `hdmi->force` removal**: Patch 10 adds `hdmi->force =3D con= nector->force;` in `dw_hdmi_connector_force()`, but this patch removes the = `force` field from the struct. Looking carefully at the diff for this patch= , the `force` assignment in `connector_force` is also removed here: ```c mutex_lock(&hdmi->mutex); - hdmi->force =3D connector->force; hdmi->last_connector_result =3D connector->status; ``` So this is correct =E2=80=94 the field and all its uses are removed atomica= lly in this patch. My earlier concern was unfounded after tracing the full = diff. **No Reviewed-by yet.** --- Generated by Claude Code Patch Reviewer