From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Use generic CEC notifier helpers Date: Sat, 16 May 2026 16:21:44 +1000 Message-ID: In-Reply-To: <20260510124111.1226584-15-jonas@kwiboo.se> References: <20260510124111.1226584-1-jonas@kwiboo.se> <20260510124111.1226584-15-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Replaces open-coded CEC notifier handling with `drm_connector_cec_phys_addr_invalidate()`, `drm_connector_cec_phys_addr_set()`, and `drmm_connector_hdmi_cec_notifier_register()`. Adds `select DRM_DISPLAY_HDMI_CEC_NOTIFIER_HELPER` to Kconfig. Removes `cec_notifier` field from `struct dw_hdmi`. The `drmm` registration handles cleanup automatically, removing the need for explicit unregister in `connector_destroy` (added in patch 8, cleaned up here). Good modernization. --- Generated by Claude Code Patch Reviewer