From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: ti: k3-am62p-j722s-common-main: Make main_conf a syscon Date: Sat, 16 May 2026 12:00:18 +1000 Message-ID: In-Reply-To: <20260513-beagley-ai-display-v2-14-9e9bcefde6bc@ideasonboard.com> References: <20260513-beagley-ai-display-v2-0-9e9bcefde6bc@ideasonboard.com> <20260513-beagley-ai-display-v2-14-9e9bcefde6bc@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Potential concern**: Adding `"syscon"` as a secondary compatible to a `"simple-bus"` node. This is a somewhat unusual pattern - typically syscon is for individual register blocks, not bus nodes with `#address-cells`/`#size-cells` and child devices. The `main_conf` node has a `reg` property covering 0x20000 bytes and children that are addressed within it. Making the entire bus a syscon means any driver can do `regmap_write()` anywhere in this 128KB range, which could interfere with child device registers. That said, the OLDI io-ctrl and DPI0_CLK_CTRL registers do live in this space, and other TI SoCs (AM625) already use a similar pattern. The DT maintainers may have opinions on this. --- Generated by Claude Code Patch Reviewer