From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: dw-hdmi-qp: Provide dw_hdmi_qp_hpd_notify() helper Date: Mon, 25 May 2026 21:15:05 +1000 Message-ID: In-Reply-To: <20260520-dw-hdmi-qp-scramb-v6-14-24b74603b782@collabora.com> References: <20260520-dw-hdmi-qp-scramb-v6-0-24b74603b782@collabora.com> <20260520-dw-hdmi-qp-scramb-v6-14-24b74603b782@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The dual-path HPD notification logic is interesting: ```c if (hdmi->curr_conn && status == connector_status_connected) drm_connector_helper_hpd_irq_event(hdmi->curr_conn); else drm_bridge_hpd_notify(&hdmi->bridge, status); ``` The comment explains the reasoning: when the pipeline is already active and a reconnection occurs, `drm_bridge_hpd_notify()` defers to a delayed hotplug path that doesn't invoke `detect_ctx()`, which is needed for SCDC recovery. Using `drm_connector_helper_hpd_irq_event()` ensures the detect path runs immediately. This is a pragmatic solution. --- Generated by Claude Code Patch Reviewer