From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915/dp: Implement "color format" DRM property
Date: Mon, 25 May 2026 18:48:56 +1000
Message-ID: <review-patch14-20260522-color-format-v15-14-21fb136c9df2@collabora.com>
In-Reply-To: <20260522-color-format-v15-14-21fb136c9df2@collabora.com>
References: <20260522-color-format-v15-0-21fb136c9df2@collabora.com> <20260522-color-format-v15-14-21fb136c9df2@collabora.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Parallel to patch 13 but for DP. The `intel_dp_attach_color_format_property` function:

```c
if (dig_port && intel_bios_encoder_is_lspcon(dig_port->base.devdata))
    has_pcon = true;
if (has_pcon || source_can_output(intel_dp, INTEL_OUTPUT_FORMAT_YCBCR420))
    fmts |= BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR420);
if (has_pcon || source_can_output(intel_dp, INTEL_OUTPUT_FORMAT_YCBCR444))
    fmts |= BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR444);
```

LSPCON (protocol converters) enabling YCbCr formats makes sense. No issues.

---
Generated by Claude Code Patch Reviewer