From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: vbios: construct `FwSecBiosImage` directly from BIOS images Date: Tue, 26 May 2026 07:03:43 +1000 Message-ID: In-Reply-To: <20260525-fix-vbios-v5-14-e5e455251537@nvidia.com> References: <20260525-fix-vbios-v5-0-e5e455251537@nvidia.com> <20260525-fix-vbios-v5-14-e5e455251537@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Major structural simplification -- removes `FwSecBiosBuilder` entirely and moves the falcon data setup into `FwSecBiosImage::new()`. This makes the data flow clearer: the FWSEC image is constructed directly from the component images rather than going through a builder that accumulates state. No issues. --- Generated by Claude Code Patch Reviewer