From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dp: separate dp_display_prepare() into its own API Date: Thu, 04 Jun 2026 13:01:25 +1000 Message-ID: In-Reply-To: <20260602-dp_mstclean-v6-14-2c17ff40a9b2@oss.qualcomm.com> References: <20260602-dp_mstclean-v6-0-2c17ff40a9b2@oss.qualcomm.com> <20260602-dp_mstclean-v6-14-2c17ff40a9b2@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Splits `msm_dp_display_atomic_enable()` into `msm_dp_display_atomic_prepare()` (mode set + link prepare) and `msm_dp_display_atomic_enable()` (stream enable + post enable). The bridge wrapper calls both sequentially; MST will insert payload allocation between them. Minor observation: in `msm_dp_display_atomic_prepare()`, if `msm_dp_display_prepare_link()` fails, the function just prints an error and returns without propagating the error to `msm_dp_display_atomic_enable()`. The subsequent `msm_dp_display_enable()` will then attempt to start the stream on a potentially broken link. This matches the pre-split behavior where `msm_dp_display_prepare_link()` failure caused an early return from `atomic_enable`, skipping the stream enable. Now the stream enable will proceed regardless. This is a **behavioral change** -- previously a prepare_link failure would skip enable; now enable runs unconditionally. --- Generated by Claude Code Patch Reviewer