From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: renesas: rz-du: mipi_dsi: Add support for RZ/G3E Date: Sun, 12 Apr 2026 12:45:58 +1000 Message-ID: In-Reply-To: <93abddcab277b570159ba3a941e6e26f55af5d62.1775636898.git.tommaso.merciai.xr@bp.renesas.com> References: <93abddcab277b570159ba3a941e6e26f55af5d62.1775636898.git.tommaso.merciai.xr@bp.renesas.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds the `rzg3e_mipi_dsi_info` hw_info struct and registers the RZ/G3E compatible. **Issue (const correctness)**: `rzg3e_mipi_dsi_info` is declared as: ```c static struct rzg2l_mipi_dsi_hw_info rzg3e_mipi_dsi_info = { ``` But both `rzv2h_mipi_dsi_info` and `rzg2l_mipi_dsi_info` are declared `const`: ```c static const struct rzg2l_mipi_dsi_hw_info rzv2h_mipi_dsi_info = { static const struct rzg2l_mipi_dsi_hw_info rzg2l_mipi_dsi_info = { ``` The `rzg3e_mipi_dsi_info` should also be `const` for consistency and safety. There's no reason for it to be mutable. **Observation**: The `rzg3e_plldsis_limits` array uses two different PLL limit structs indexed by `vclk_idx`, while `rzv2h_plldsi_limits` uses a single set (same limits duplicated). This cleanly implements the design described in the commit message. --- Generated by Claude Code Patch Reviewer