public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: analogix_dp: Apply panel_bridge helper
Date: Wed, 11 Feb 2026 16:37:19 +1000	[thread overview]
Message-ID: <review-patch15-20260210091024.2732369-2-damon.ding@rock-chips.com> (raw)
In-Reply-To: <20260210091024.2732369-2-damon.ding@rock-chips.com>

Patch Review

**Summary:** Wraps panels as bridges using devm_drm_panel_bridge_add().

```c
+	if (dp->plat_data->panel) {
+		dp->plat_data->next_bridge = devm_drm_panel_bridge_add(dp->dev,
+								       dp->plat_data->panel);
+		if (IS_ERR(dp->plat_data->next_bridge)) {
+			ret = PTR_ERR(bridge);
+			goto err_unregister_aux;
+		}
+	}
```

**CRITICAL BUG:**
```c
ret = PTR_ERR(bridge);
```
Should be:
```c
ret = PTR_ERR(dp->plat_data->next_bridge);
```

This returns the wrong error value!

**Other changes reviewed:**
- Removes explicit panel prepare/enable/disable calls (now handled by panel_bridge)
- Removes `analogix_dp_bridge_get_modes()` (panel_bridge provides this)
- Changes bridge->ops from conditional to always `DRM_BRIDGE_OP_EDID | DRM_BRIDGE_OP_DETECT`

**Verdict:** **NEEDS REVISION** - Fix the PTR_ERR bug.

---

## SUMMARY OF ISSUES

**Critical:**
1. PATCH 15: Wrong variable in PTR_ERR() - returns error value of wrong pointer
2. PATCH 7: Modifying display_info in atomic_check violates atomic principles

**Minor:**
1. PATCH 1: Typo in commit message ("attachmenet")
2. PATCH 2: Verify author attribution change is intentional

**Recommendations:**
- Fix the critical bug in PATCH 15
- Reconsider the approach in PATCH 7 for color format handling
- Otherwise, this is a well-structured refactoring series

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-02-11  6:37 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10  7:12 [PATCH v9 00/15] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Damon Ding
2026-02-10  7:12 ` [PATCH v9 01/15] drm/bridge: analogix_dp: Add &analogix_dp_plat_data.next_bridge Damon Ding
2026-02-11  6:37   ` Claude review: " Claude Code Review Bot
2026-02-10  7:12 ` [PATCH v9 02/15] drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use Damon Ding
2026-02-11  6:37   ` Claude review: " Claude Code Review Bot
2026-02-10  7:12 ` [PATCH v9 03/15] drm/exynos: exynos_dp: Remove &exynos_dp_device.ptn_bridge Damon Ding
2026-02-11  6:37   ` Claude review: " Claude Code Review Bot
2026-02-10  7:12 ` [PATCH v9 04/15] drm/exynos: exynos_dp: Remove unused &exynos_dp_device.connector Damon Ding
2026-02-11  6:37   ` Claude review: " Claude Code Review Bot
2026-02-10  7:12 ` [PATCH v9 05/15] drm/exynos: exynos_dp: Apply of-display-mode-bridge to parse the display-timings node Damon Ding
2026-02-11  6:37   ` Claude review: " Claude Code Review Bot
2026-02-10  7:12 ` [PATCH v9 06/15] drm/bridge: analogix_dp: Remove redundant &analogix_dp_plat_data.skip_connector Damon Ding
2026-02-11  6:37   ` Claude review: " Claude Code Review Bot
2026-02-10  7:12 ` [PATCH v9 07/15] drm/bridge: analogix_dp: Move the color format check to .atomic_check() for Rockchip platforms Damon Ding
2026-02-11  6:37   ` Claude review: " Claude Code Review Bot
2026-02-10  7:12 ` [PATCH v9 08/15] drm/bridge: analogix_dp: Remove unused &analogix_dp_plat_data.get_modes() Damon Ding
2026-02-11  6:37   ` Claude review: " Claude Code Review Bot
2026-02-10  7:12 ` [PATCH v9 09/15] drm/bridge: analogix_dp: Apply drm_bridge_connector helper Damon Ding
2026-02-11  6:37   ` Claude review: " Claude Code Review Bot
2026-02-10  7:12 ` [PATCH v9 10/15] drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe() Damon Ding
2026-02-11  6:37   ` Claude review: " Claude Code Review Bot
2026-02-10  7:12 ` [PATCH v9 11/15] drm/rockchip: analogix_dp: Apply analogix_dp_finish_probe() Damon Ding
2026-02-11  6:37   ` Claude review: " Claude Code Review Bot
2026-02-10  7:12 ` [PATCH v9 12/15] drm/exynos: exynos_dp: " Damon Ding
2026-02-11  6:37   ` Claude review: " Claude Code Review Bot
2026-02-10  7:12 ` [PATCH v9 13/15] drm/bridge: analogix_dp: Attach the next bridge in analogix_dp_bridge_attach() Damon Ding
2026-02-11  6:37   ` Claude review: " Claude Code Review Bot
2026-02-10  9:10 ` [PATCH v9 14/15] drm/bridge: analogix_dp: Remove bridge disabing and panel unpreparing in analogix_dp_unbind() Damon Ding
2026-02-10  9:10   ` [PATCH v9 15/15] drm/bridge: analogix_dp: Apply panel_bridge helper Damon Ding
2026-02-11  6:37     ` Claude Code Review Bot [this message]
2026-02-11  6:37   ` Claude review: drm/bridge: analogix_dp: Remove bridge disabing and panel unpreparing in analogix_dp_unbind() Claude Code Review Bot
2026-02-11  6:37 ` Claude review: Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch15-20260210091024.2732369-2-damon.ding@rock-chips.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox