From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: analogix_dp: Apply panel_bridge helper
Date: Wed, 11 Feb 2026 16:37:19 +1000
Message-ID: <review-patch15-20260210091024.2732369-2-damon.ding@rock-chips.com>
In-Reply-To: <20260210091024.2732369-2-damon.ding@rock-chips.com>
References: <20260210071225.2566099-1-damon.ding@rock-chips.com> <20260210091024.2732369-2-damon.ding@rock-chips.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Mailer: Claude Code Patch Reviewer

Patch Review

**Summary:** Wraps panels as bridges using devm_drm_panel_bridge_add().

```c
+	if (dp->plat_data->panel) {
+		dp->plat_data->next_bridge = devm_drm_panel_bridge_add(dp->dev,
+								       dp->plat_data->panel);
+		if (IS_ERR(dp->plat_data->next_bridge)) {
+			ret = PTR_ERR(bridge);
+			goto err_unregister_aux;
+		}
+	}
```

**CRITICAL BUG:**
```c
ret = PTR_ERR(bridge);
```
Should be:
```c
ret = PTR_ERR(dp->plat_data->next_bridge);
```

This returns the wrong error value!

**Other changes reviewed:**
- Removes explicit panel prepare/enable/disable calls (now handled by panel_bridge)
- Removes `analogix_dp_bridge_get_modes()` (panel_bridge provides this)
- Changes bridge->ops from conditional to always `DRM_BRIDGE_OP_EDID | DRM_BRIDGE_OP_DETECT`

**Verdict:** **NEEDS REVISION** - Fix the PTR_ERR bug.

---

## SUMMARY OF ISSUES

**Critical:**
1. PATCH 15: Wrong variable in PTR_ERR() - returns error value of wrong pointer
2. PATCH 7: Modifying display_info in atomic_check violates atomic principles

**Minor:**
1. PATCH 1: Typo in commit message ("attachmenet")
2. PATCH 2: Verify author attribution change is intentional

**Recommendations:**
- Fix the critical bug in PATCH 15
- Reconsider the approach in PATCH 7 for color format handling
- Otherwise, this is a well-structured refactoring series

---
Generated by Claude Code Patch Reviewer