From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Set relevant Downspread Ctrl DPCD bits for PR + Auxless ALPM Date: Thu, 12 Mar 2026 06:55:31 +1000 Message-ID: In-Reply-To: <20260311113611.3393194-16-ankit.k.nautiyal@intel.com> References: <20260311113611.3393194-1-ankit.k.nautiyal@intel.com> <20260311113611.3393194-16-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Extends `intel_dp_link_training_set_mode()` with a `is_pr_with_link_off` parameter to set `DP_FIXED_VTOTAL_AS_SDP_EN_IN_PR_ACTIVE` in DPCD 0x0107. The condition used in `intel_dp_update_downspread_ctrl()` is: ```c intel_alpm_is_alpm_aux_less(intel_dp, crtc_state) ``` This checks if auxless ALPM is active, which implies PR with link-off. Seems correct per the spec reference. **Concern about the condition:** The commit message says this bit should be set "whether VRR is enabled (AVT/FAVT) or fixed-timing mode is used", meaning any time PR+auxless-ALPM is active. But `intel_alpm_is_alpm_aux_less()` may return true even without AS SDP support. Should this be gated on AS SDP being available too? --- Generated by Claude Code Patch Reviewer