From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: MAINTAINERS: Add maintainer entry for Qualcomm PAS TZ service
Date: Fri, 13 Mar 2026 14:26:35 +1000 [thread overview]
Message-ID: <review-patch15-20260312062756.694390-16-sumit.garg@kernel.org> (raw)
In-Reply-To: <20260312062756.694390-16-sumit.garg@kernel.org>
Patch Review
Straightforward. Uses the `@oss.qualcomm.com` email, while the `From:` line on the cover letter uses `@kernel.org`. The MAINTAINERS entry should probably use the `@kernel.org` address for longevity, as the oss.qualcomm.com address may change if the maintainer changes employers.
---
**Summary of key issues:**
1. **Kconfig `select` vs `depends on` mismatch** (Patch 9): `select QCOM_PAS_TEE` can break builds when TEE is disabled.
2. **Global ops_ptr has no teardown protection** (Patch 2): Use-after-free risk if unregister races with active calls.
3. **Type-unsafe casts between `qcom_scm_pas_context` and `qcom_pas_context`** (Patch 3): Transitional but fragile.
4. **`get_rsc_table` ops return type mismatch** (Patch 2): `void *` in ops vs `struct resource_table *` in public API.
5. **Copy-paste error message** (Patch 4): "PAS shutdown failed" in `set_remote_state`.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-13 4:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 6:27 [PATCH v2 00/15] firmware: qcom: Add OP-TEE PAS service support Sumit Garg
2026-03-12 6:27 ` [PATCH v2 01/15] arm64: dts: qcom: kodiak: Add EL2 overlay Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 02/15] firmware: qcom: Add a generic PAS service Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 03/15] firmware: qcom_scm: Migrate to " Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 04/15] firmware: qcom: Add a PAS TEE service Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 05/15] remoteproc: qcom_q6v5_pas: Switch over to generic PAS TZ APIs Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 06/15] remoteproc: qcom_q6v5_mss: Switch " Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 07/15] soc: qcom: mdtloader: " Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 08/15] remoteproc: qcom_wcnss: " Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 09/15] remoteproc: qcom: Select QCOM_PAS_TEE service backend Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 10/15] drm/msm: Switch to generic PAS TZ APIs Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 11/15] media: qcom: " Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 12/15] net: ipa: " Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 13/15] wifi: ath12k: " Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 14/15] firmware: qcom_scm: Remove SCM PAS wrappers Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 15/15] MAINTAINERS: Add maintainer entry for Qualcomm PAS TZ service Sumit Garg
2026-03-13 4:26 ` Claude Code Review Bot [this message]
2026-03-13 4:26 ` Claude review: firmware: qcom: Add OP-TEE PAS service support Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch15-20260312062756.694390-16-sumit.garg@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox