From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: MAINTAINERS: Add maintainer entry for Qualcomm PAS TZ service Date: Fri, 13 Mar 2026 14:26:35 +1000 Message-ID: In-Reply-To: <20260312062756.694390-16-sumit.garg@kernel.org> References: <20260312062756.694390-1-sumit.garg@kernel.org> <20260312062756.694390-16-sumit.garg@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Straightforward. Uses the `@oss.qualcomm.com` email, while the `From:` line on the cover letter uses `@kernel.org`. The MAINTAINERS entry should probably use the `@kernel.org` address for longevity, as the oss.qualcomm.com address may change if the maintainer changes employers. --- **Summary of key issues:** 1. **Kconfig `select` vs `depends on` mismatch** (Patch 9): `select QCOM_PAS_TEE` can break builds when TEE is disabled. 2. **Global ops_ptr has no teardown protection** (Patch 2): Use-after-free risk if unregister races with active calls. 3. **Type-unsafe casts between `qcom_scm_pas_context` and `qcom_pas_context`** (Patch 3): Transitional but fragile. 4. **`get_rsc_table` ops return type mismatch** (Patch 2): `void *` in ops vs `struct resource_table *` in public API. 5. **Copy-paste error message** (Patch 4): "PAS shutdown failed" in `set_remote_state`. --- Generated by Claude Code Patch Reviewer