From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: phy: move provider API out of public Date: Sun, 22 Mar 2026 04:07:14 +1000 Message-ID: In-Reply-To: <20260319223241.1351137-16-vladimir.oltean@nxp.com> References: <20260319223241.1351137-1-vladimir.oltean@nxp.com> <20260319223241.1351137-16-vladimir.oltean@nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This is the core patch. Creates: - `drivers/phy/phy-provider.h` (256 lines) -- struct phy, struct phy_ops, struct phy_provider, struct phy_attrs, provider registration macros, `phy_set_drvdata()`/`phy_get_drvdata()` - `include/linux/phy/phy-props.h` (75 lines) -- enum phy_mode, enum phy_media, union phy_configure_opts, etc. Converts `phy_get_mode()`, `phy_get_bus_width()`, `phy_set_bus_width()` from static inlines to exported symbols. Moves `to_phy()` macro and `struct phy_lookup` into `phy-core.c` (they're internal). The temporary compatibility line `#include "../../../drivers/phy/phy-provider.h"` in `phy.h` is ugly but explicitly temporary (removed in patch 26). The guard rename from `__DRIVERS_PHY_H` to `__PHY_CONSUMER_H` is appropriate. The `#else` stubs in the consumer header are properly reorganized -- consumer get/put stubs come first, then operation stubs. Provider stubs are only in `phy-provider.h`. Minor style note: the new file header in `phy-props.h` says `phy-provider.h` in the comment. This is a copy-paste oversight: ```c + * phy-provider.h -- Generic PHY properties ``` Should say `phy-props.h -- Generic PHY properties`. --- Generated by Claude Code Patch Reviewer