From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/drv: Call drm_mode_config_create_state() by default Date: Sun, 22 Mar 2026 03:32:28 +1000 Message-ID: In-Reply-To: <20260320-drm-mode-config-init-v2-15-c63f1134e76c@kernel.org> References: <20260320-drm-mode-config-init-v2-0-c63f1134e76c@kernel.org> <20260320-drm-mode-config-init-v2-15-c63f1134e76c@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Hooks `drm_mode_config_create_state()` into `drm_dev_register()`. This is the right place since it runs after all objects are created. **Concern**: The `err_unload` label runs `driver->unload()` but doesn't undo the state allocations done by `drm_mode_config_create_state()`. That said, the states are attached to the objects which will be cleaned up by `drm_mode_config_cleanup()` eventually, so this should be fine as long as the normal teardown path handles it. Worth confirming that `drm_mode_config_cleanup()` frees these states. --- Generated by Claude Code Patch Reviewer