From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/ast: Fix open-coded scu_rev access Date: Wed, 25 Mar 2026 07:46:43 +1000 Message-ID: In-Reply-To: <20260323160407.245773-16-tzimmermann@suse.de> References: <20260323160407.245773-1-tzimmermann@suse.de> <20260323160407.245773-16-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean final patch. Replaces the manual P2A setup for reading SCU7C with `__ast_mindwm`. The addition of `AST_REG_SCU07C_CHIP_BONDING_MASK` (`GENMASK(15, 8)`) is a nice touch for documenting which bits are actually used. **Behavioral concern**: The old code read the full 32-bit `scu_rev` value and stored it as-is. The new code masks it: ```c scu_rev = scu07c & AST_REG_SCU07C_CHIP_BONDING_MASK; ``` I'd want to verify that downstream consumers of `scu_rev` only care about bits [15:8]. Looking at the cover letter, this was smoke-tested, so it's likely correct, but this is a functional change worth noting - if any code path checks bits outside the mask, it would break. --- Generated by Claude Code Patch Reviewer