From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: jadard-jd9365da-h3: support Waveshare WXGA DSI panels Date: Sun, 12 Apr 2026 09:06:56 +1000 Message-ID: In-Reply-To: <20260411-waveshare-dsi-touch-v2-15-75cdbeac5156@oss.qualcomm.com> References: <20260411-waveshare-dsi-touch-v2-0-75cdbeac5156@oss.qualcomm.com> <20260411-waveshare-dsi-touch-v2-15-75cdbeac5156@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds Waveshare 8.0" and 10.1" WXGA (800x1280) panels with lane-conditional init sequences. 1. **Bug**: `waveshare_8_0_a_init()` returns `0` instead of `dsi_ctx.accum_err`: ```c msleep(60); return 0; ``` Any DSI write errors during init will be silently ignored. 2. **Readability**: `waveshare_10_1_a_init()` has extensive inline `if (jadard->dsi->lanes == 4) ... else ...` conditionals scattered throughout the gamma and GIP configuration, making it very hard to audit. Consider splitting into two separate init sequences or at minimum using lookup tables indexed by lane count. 3. **Style**: Inconsistent braces -- `if` branch without braces, `else` branch with braces in several places, violating kernel coding style. --- --- Generated by Claude Code Patch Reviewer