From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vkms: Introduce config for plane rotation Date: Thu, 23 Apr 2026 07:30:14 +1000 Message-ID: In-Reply-To: <20260422-vkms-all-config-v4-15-dbb52e9aadc3@bootlin.com> References: <20260422-vkms-all-config-v4-0-dbb52e9aadc3@bootlin.com> <20260422-vkms-all-config-v4-15-dbb52e9aadc3@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Bug: format string misuse.** The `show_bitfield` helper does: ```c seq_printf(m, callback(offset)); ``` This uses the return value of `callback` (a `const char *`) as the format string for `seq_printf`. Even though these strings are static constants here, this is a format-string vulnerability pattern. Use `seq_puts(m, callback(offset))` instead. The rotation validation logic and tests are thorough. Good use of `VISIBLE_IF_KUNIT`. --- Generated by Claude Code Patch Reviewer