From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: MAINTAINERS: Add maintainer entry for Qualcomm PAS TZ service Date: Tue, 28 Apr 2026 14:49:26 +1000 Message-ID: In-Reply-To: <20260427095603.1157963-16-sumit.garg@kernel.org> References: <20260427095603.1157963-1-sumit.garg@kernel.org> <20260427095603.1157963-16-sumit.garg@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Straightforward MAINTAINERS entry. Covers all four new/modified files. No issues. --- **Summary of issues found:** 1. **Bug (Patch 13):** `ath12k_err` format string `%d: %d` has two format specifiers but only one argument -- missing `ret`. 2. **Potential issue (Patch 2):** `ops_ptr` TOCTOU race -- each exported function reads the global pointer twice without synchronization. Low practical risk but worth fixing. 3. **Stale comment (Patch 2):** `qcom_scm_pas_context_init()` reference should be `devm_qcom_pas_context_alloc()`. 4. **Copy-paste error (Patch 4):** `qcom_pas_tee_set_remote_state()` error message says "PAS shutdown failed" instead of "PAS set remote state failed". 5. **Uninitialized output (Patch 4):** `qcom_pas_tee_get_rsc_table()` doesn't set `*output_rt_size` in the zero-size path. 6. **Minor (Patch 2):** `qcom_pas_ops_register()` returns void even on failure; `drv_name` field is unused. --- Generated by Claude Code Patch Reviewer