From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: phy: move provider API out of public Date: Tue, 05 May 2026 10:35:04 +1000 Message-ID: In-Reply-To: <20260430110652.558622-16-vladimir.oltean@nxp.com> References: <20260430110652.558622-1-vladimir.oltean@nxp.com> <20260430110652.558622-16-vladimir.oltean@nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This is the central patch of the series. It: 1. **Creates `include/linux/phy/phy-props.h`**: Shared types used by both consumers and providers (`enum phy_mode`, `enum phy_media`, `union phy_configure_opts`, etc.) 2. **Creates `drivers/phy/phy-provider.h`**: Private header containing `struct phy`, `struct phy_ops`, `struct phy_provider`, and all provider-side function declarations (`phy_create`, `devm_of_phy_provider_register`, etc.) 3. **Slims `include/linux/phy/phy.h`**: Now only exposes consumer API. `struct phy` becomes a forward-declared opaque pointer. All `phy_get*()`, `phy_power_on()`, etc. remain. Converts `phy_get_mode()`, `phy_get_bus_width()`, `phy_set_bus_width()` from static inlines to proper exported functions (necessary because consumers can no longer see `struct phy` internals). 4. **Temporary compatibility**: Includes `phy-provider.h` from `phy.h` with a comment that this will be removed (done in patch 26). The header guard rename from `__DRIVERS_PHY_H` to `__PHY_CONSUMER_H` is appropriate. Reviewed-by: Dmitry Baryshkov. Well-designed split. --- Generated by Claude Code Patch Reviewer