From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: firmware: qcom_scm: Remove SCM PAS wrappers Date: Tue, 05 May 2026 08:22:46 +1000 Message-ID: In-Reply-To: <20260504130603.1474043-16-sumit.garg@kernel.org> References: <20260504130603.1474043-1-sumit.garg@kernel.org> <20260504130603.1474043-16-sumit.garg@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This is the cleanup patch that removes the transitional wrappers added in patch 3. All the `__`-prefixed functions get renamed back to clean names, the exported thin wrappers are removed, and the `qcom_scm_pas_context` typedef is removed from `qcom_scm.h`. The `qcom_pas_ops_scm` struct is updated to reference the cleaned-up function names. The diff is large but mechanical and correct. **One observation:** `qcom_scm_set_remote_state()` is also removed from the exports and header here. This is correct since all callers were migrated in earlier patches. No issues. --- --- Generated by Claude Code Patch Reviewer