From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/connector: Add new atomic_create_state callback Date: Sat, 16 May 2026 13:22:55 +1000 Message-ID: In-Reply-To: <20260512-drm-mode-config-init-v4-15-591dfdcc1bf9@kernel.org> References: <20260512-drm-mode-config-init-v4-0-591dfdcc1bf9@kernel.org> <20260512-drm-mode-config-init-v4-15-591dfdcc1bf9@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Same pattern as patches 10/12. The fallback in `drm_mode_config_reset()` is: ```c drm_for_each_connector_iter(connector, &conn_iter) { if (connector->funcs->reset) connector->funcs->reset(connector); else if (connector->funcs->atomic_create_state) drm_mode_config_connector_reset_with_create_state(connector); } ``` Since `drm_mode_config_reset()` is void and errors from the reset-with-create path are dropped (same as plane/crtc), the connector iter is always properly ended. Fine. No issues. --- Generated by Claude Code Patch Reviewer