From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: ti: k3-am62p-j722s-common-main: Add support for DSS Date: Sat, 16 May 2026 12:00:18 +1000 Message-ID: In-Reply-To: <20260513-beagley-ai-display-v2-15-9e9bcefde6bc@ideasonboard.com> References: <20260513-beagley-ai-display-v2-0-9e9bcefde6bc@ideasonboard.com> <20260513-beagley-ai-display-v2-15-9e9bcefde6bc@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Large DTS patch adding DSS0, DSS1, OLDI, DPHY, and DSI nodes. The structure follows the pattern described in the cover letter and binding patches. **Observation**: Both DSS0 and DSS1 point to the same `ti,dpi-io-ctrl` offset: ``` ti,dpi-io-ctrl = <&main_conf 0x8300>; ``` This implies both DSS instances share a single DPI0_CLK_CTRL register. If both DSSes try to use DPI simultaneously with different edge configs, they would conflict. This is presumably handled by the "only one VP can output to DPI" constraint mentioned in the binding. The fixed-factor-clock nodes in `k3-am62p.dtsi` and `k3-j722s.dtsi` are duplicated. This is necessary since they're different SoC .dtsi files, so it's correct. --- Generated by Claude Code Patch Reviewer