From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: Add YUV422 output mode constants for VOP2 Date: Mon, 25 May 2026 18:48:56 +1000 Message-ID: In-Reply-To: <20260522-color-format-v15-15-21fb136c9df2@collabora.com> References: <20260522-color-format-v15-0-21fb136c9df2@collabora.com> <20260522-color-format-v15-15-21fb136c9df2@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Straightforward constant definitions. The `ROCKCHIP_OUT_MODE_YUV422 = 9` and RK3576-specific values (12, 13) match TRM documentation per the commit message. Note: `ROCKCHIP_OUT_MODE_YUV422_RK3576_DP = 12` collides with `ROCKCHIP_OUT_MODE_S888_DUMMY = 12`. These are used in different contexts (the RK3576 ones are only used for RK3576's connector-specific output mode selection in patch 18), so there's no actual conflict, but it's worth noting. --- Generated by Claude Code Patch Reviewer