From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: Add YUV422 output mode constants for VOP2 Date: Mon, 25 May 2026 17:26:11 +1000 Message-ID: In-Reply-To: <20260523-color-format-v16-15-24340c5e4732@collabora.com> References: <20260523-color-format-v16-0-24340c5e4732@collabora.com> <20260523-color-format-v16-15-24340c5e4732@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Simple constant definitions. The RK3576-specific constants (`ROCKCHIP_OUT_MODE_YUV422_RK3576_DP` = 12, `ROCKCHIP_OUT_MODE_YUV422_RK3576_HDMI` = 13) being distinct from the generic `ROCKCHIP_OUT_MODE_YUV422` = 9 reflects the hardware having per-connector YUV422 encodings on RK3576. **Note:** `ROCKCHIP_OUT_MODE_YUV422_RK3576_DP` = 12 shares the same value as `ROCKCHIP_OUT_MODE_S888_DUMMY` = 12. This is intentional (the register field is reused differently on RK3576), but could be confusing. A comment would help. --- Generated by Claude Code Patch Reviewer