From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: ti: beagley-ai: Enable HDMI display and audio Date: Thu, 04 Jun 2026 16:54:13 +1000 Message-ID: In-Reply-To: <20260529-beagley-ai-display-v3-15-7fefdc5d1adf@ideasonboard.com> References: <20260529-beagley-ai-display-v3-0-7fefdc5d1adf@ideasonboard.com> <20260529-beagley-ai-display-v3-15-7fefdc5d1adf@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Enables HDMI via the IT66122 bridge chip on I2C1, with DSS1 VP0 driving 24-= bit parallel video to the bridge. Also sets up MCASP1 for HDMI audio via si= mple-audio-card. **Observations:** - The DT uses DSS1 VP0 for HDMI with a comment noting VP choice. Good docum= entation. - The `bootph-all` on `main_i2c1_pins_default` seems unnecessary for a disp= lay path that shouldn't be needed in early boot, but it's harmless. - The `auxclk-fs-ratio =3D <2177>` for MCASP is an unusual value. The cover= letter mentions "Sample-rate is off by 400 PPM" which suggests this ratio = doesn't perfectly divide the master clock for standard audio sample rates, = but 400 PPM is within typical acceptable limits. - The pin mux for MCASP1_AXR0 is set as `PIN_OUTPUT` which is correct for T= X. No blocking issues. **Summary:** The series is well-prepared for v3 with proper error handling = improvements from v2. The main area I'd suggest looking at is the unconditi= onal `clk_put(oldi->serial)` in the OLDI aux driver remove/error paths (pat= ch 12) =E2=80=94 while it's likely safe due to zeroed allocation, it would = be cleaner to guard with a NULL check or mirror the conditional from probe.= The rest looks solid and ready for merging. --- Generated by Claude Code Patch Reviewer