From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dp: pass panel to display enable/disable helpers Date: Thu, 04 Jun 2026 13:01:25 +1000 Message-ID: In-Reply-To: <20260602-dp_mstclean-v6-15-2c17ff40a9b2@oss.qualcomm.com> References: <20260602-dp_mstclean-v6-0-2c17ff40a9b2@oss.qualcomm.com> <20260602-dp_mstclean-v6-15-2c17ff40a9b2@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Passes `msm_dp_panel` explicitly to `msm_dp_display_enable()` and `msm_dp_display_disable()`. Minor inconsistency in `msm_dp_display_disable()`: the `msm_dp_ctrl_off_link()` call at line ~5268 still uses `dp->panel` directly rather than the passed `msm_dp_panel` parameter: ```c msm_dp_ctrl_off_link(dp->ctrl, dp->panel); ``` This should probably be: ```c msm_dp_ctrl_off_link(dp->ctrl, msm_dp_panel); ``` For SST this makes no difference (they're the same pointer), but for MST consistency and correctness this looks like a bug -- the whole point of passing panel explicitly is to support per-stream panels. **Issue: `dp->panel` used instead of `msm_dp_panel` in `msm_dp_ctrl_off_link()` call within `msm_dp_display_disable()`.** This should be fixed before merge. --- Generated by Claude Code Patch Reviewer