From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/simple-kms: Deprecate simple-kms helpers Date: Sun, 22 Mar 2026 04:15:36 +1000 Message-ID: In-Reply-To: <20260319160110.109610-17-tzimmermann@suse.de> References: <20260319160110.109610-1-tzimmermann@suse.de> <20260319160110.109610-17-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Removes documentation for simple-kms helpers and adds TODO items for conver= ting remaining users. Issues: 1. **Two typos in the deprecation comment** added to `drm_simple_kms_helper= .h`: ```c * Simple KMS helpers are deprected in favor of regular atomic helpers. D= o not * use the min new code. ``` - `"deprected"` =E2=86=92 `"deprecated"` - `"use the min new code"` =E2=86=92 `"use them in new code"` (or simila= r =E2=80=94 `"the min"` doesn't make sense) 2. **Typo in TODO** at line 5222: `"inlined fucntions"` =E2=86=92 `"inlined= functions"`. 3. The approach of stripping all kernel-doc from `drm_simple_kms_helper.h` = and `drm_simple_kms_helper.c` while keeping the code functional is reasonab= le for deprecation, though it's a bit aggressive =E2=80=94 typically deprec= ated APIs retain their docs with a deprecation notice. However, since the g= oal is to strongly discourage use, this is defensible. --- Generated by Claude Code Patch Reviewer