From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/adreno: Expose a PARAM to check AQE support Date: Wed, 25 Mar 2026 07:32:12 +1000 Message-ID: In-Reply-To: <20260324-a8xx-gpu-batch2-v1-16-fc95b8d9c017@oss.qualcomm.com> References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> <20260324-a8xx-gpu-batch2-v1-16-fc95b8d9c017@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `MSM_PARAM_AQE` (0x17) UAPI parameter to query AQE (Application QRISC Engine) support. The check requires both preemption enabled (nr_rings > 1) and AQE firmware loaded (aqe_bo != NULL). **Typo in commit message:** "Applicaton Qrisc" should be "Application QRISC". **UAPI concern:** New UAPI should typically have documentation in the header or commit message about what the value means to userspace. The comment `/* RO */` is minimal. **Extra space:** ```c *value = (adreno_gpu->funcs->aqe_is_enabled && ``` Two spaces after `=`. **Note:** `aqe_is_enabled` is only set for `a7xx_gpu_funcs` and `a8xx_gpu_funcs`, not for `a6xx_gpu_funcs` or `a6xx_gmuwrapper_funcs`. The NULL check in `adreno_get_param()` handles this correctly by returning 0. --- Generated by Claude Code Patch Reviewer