From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Set relevant Downspread Ctrl DPCD bits for PR + Auxless ALPM Date: Tue, 31 Mar 2026 17:39:48 +1000 Message-ID: In-Reply-To: <20260330040656.4116502-17-ankit.k.nautiyal@intel.com> References: <20260330040656.4116502-1-ankit.k.nautiyal@intel.com> <20260330040656.4116502-17-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The function signature change adds a `bool is_pr_with_link_off` parameter. = The condition: ```c + link_config[0] |=3D is_pr_with_link_off ? DP_FIXED_VTOTAL_AS_SDP_EN_IN_PR= _ACTIVE : 0; ``` This sets bit 6 of DPCD 0x107 when Panel Replay with link-off is active, wh= ich matches the spec definition. The call site passes `intel_alpm_is_alpm_a= ux_less(intel_dp, crtc_state)` which is correct. The MST caller passes `false` for the new parameter =E2=80=94 correct since= MST doesn't use PR with link-off. No R-b tag. --- Generated by Claude Code Patch Reviewer