From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vkms: Introduce configfs for plane rotation Date: Thu, 23 Apr 2026 07:30:14 +1000 Message-ID: In-Reply-To: <20260422-vkms-all-config-v4-16-dbb52e9aadc3@bootlin.com> References: <20260422-vkms-all-config-v4-0-dbb52e9aadc3@bootlin.com> <20260422-vkms-all-config-v4-16-dbb52e9aadc3@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Bug: type mismatch.** Both `plane_supported_rotations_store` and `plane_default_rotation_store` declare `int ret, val = 0;` then pass `&val` to `kstrtouint()`, which expects `unsigned int *`. Passing an `int *` is a type error. Change `val` to `unsigned int`. Also, the `_show` functions use `sprintf(page, ...)` instead of `sysfs_emit()`. While configfs historically uses sprintf, new code should prefer `sysfs_emit()` for buffer safety. --- Generated by Claude Code Patch Reviewer