From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Use delayed_work to debounce hotplug event Date: Sat, 16 May 2026 16:21:45 +1000 Message-ID: In-Reply-To: <20260510124111.1226584-17-jonas@kwiboo.se> References: <20260510124111.1226584-1-jonas@kwiboo.se> <20260510124111.1226584-17-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The core of the HPD rework. Introduces a 1100ms debounce via `delayed_work`= for hotplug events, with `enable_delayed_work()`/`disable_delayed_work()` = gating from `enable_hpd`/`hpd_enable` callbacks: ```c + mod_delayed_work(system_percpu_wq, &hdmi->hpd_work, + msecs_to_jiffies(HOTPLUG_DEBOUNCE_MS)); ``` The 1100ms debounce exceeds the HDMI spec's "at least 100 msec" HPD pulse, = with margin. The `system_percpu_wq` usage is acceptable =E2=80=94 the work = is lightweight (calls `drm_helper_hpd_irq_event()`). The `cancel_delayed_wo= rk_sync()` calls in remove and suspend paths are correct. The work is properly disabled after `INIT_DELAYED_WORK` and only enabled wh= en HPD monitoring begins. Good design. --- Generated by Claude Code Patch Reviewer