From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/a6xx: Allow IFPC with perfcntr stream Date: Sat, 16 May 2026 15:20:25 +1000 Message-ID: In-Reply-To: <20260511130017.96867-17-robin.clark@oss.qualcomm.com> References: <20260511130017.96867-1-robin.clark@oss.qualcomm.com> <20260511130017.96867-17-robin.clark@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Changes `sysprof_setup()` signature to add `bool force_on` to temporarily inhibit IFPC during counter sampling. Updates `msm_gpu_sysprof_no_ifpc()` to only look at the legacy SYSPROF param, no longer at perfcntr stream presence. The approach of bracketing counter reads with `sysprof_setup(true/false)` in `sample_worker` is clean. The suspend path cancels the timer and waits for the work to complete before proceeding, preventing races. Minor: commit message typo "on exist of IFPC" should be "on exit of IFPC" (same typo appears in patch 13's commit message). --- Generated by Claude Code Patch Reviewer