From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: ti: beagley-ai: Enable HDMI display and audio Date: Sat, 16 May 2026 12:00:19 +1000 Message-ID: In-Reply-To: <20260513-beagley-ai-display-v2-16-9e9bcefde6bc@ideasonboard.com> References: <20260513-beagley-ai-display-v2-0-9e9bcefde6bc@ideasonboard.com> <20260513-beagley-ai-display-v2-16-9e9bcefde6bc@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Board DTS enabling HDMI via IT66122 bridge on DSS1-VP1 with DPI output, plus HDMI audio via McASP1. Well structured with proper pinctrl, power supply, and interrupt configuration. **Minor note**: The `assigned-clock-parents` comment: ``` assigned-clock-parents = <&k3_clks 241 2>, /* PLL 17 HDMI */ <&k3_clks 240 1>, /* PLL 18 DSI */ ``` VP1 is used for HDMI but its parent is labeled "PLL 18 DSI" - this is just the PLL name, not a functional issue, but worth noting the clock routing might be less obvious to future readers. No blocking issues. --- **Summary**: The series is well-crafted with good separation of concerns. The main items to address: 1. **Patch 9**: Remove the `+ 0x0` in the regmap_write offset. 2. **Patch 12**: Consider using `pm_runtime_resume_and_get()` instead of `pm_runtime_get_sync()`. Also rename the misleading `err_put_node` label. 3. **Patch 14**: The syscon-on-simple-bus pattern may draw DT reviewer comments, though it appears to be an established TI pattern. --- Generated by Claude Code Patch Reviewer