From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: vbios: use single logical block for the FWSEC section
Date: Tue, 26 May 2026 07:03:44 +1000 [thread overview]
Message-ID: <review-patch16-20260525-fix-vbios-v5-16-e5e455251537@nvidia.com> (raw)
In-Reply-To: <20260525-fix-vbios-v5-16-e5e455251537@nvidia.com>
Patch Review
This is the biggest patch in the series. It replaces the two-FWSEC-image model with a single contiguous `fwsec_section: KVVec<u8>` that includes all images from the first FWSEC onward. This simplifies the offset calculations since offsets into the FWSEC region no longer need to account for two separate images.
The change from `KVec` to `KVVec` for `BiosImage.data` (since `KVVec` can be constructed from a borrowed slice) and the removal of the `dev` field from `BiosImage` are well-motivated by this refactoring.
**Minor observation:** The documentation update in `Documentation/gpu/nova/core/vbios.rst` changes "second fwsec" to "fwsec" which is consistent with the new model.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 21:03 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 13:57 [PATCH v5 00/22] gpu: nova-core: vbios: harden various array accesses and refactor Eliot Courtney
2026-05-25 13:57 ` [PATCH v5 01/22] gpu: nova-core: vbios: stop scanning at BIOS_MAX_SCAN_LEN Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 02/22] gpu: nova-core: vbios: use checked arithmetic for bios image range end Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 03/22] gpu: nova-core: vbios: avoid reading too far in read_more_at_offset Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 04/22] gpu: nova-core: vbios: read BitToken using FromBytes Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 05/22] gpu: nova-core: vbios: use checked ops and accesses in `FwSecBiosImage::ucode` Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 06/22] gpu: nova-core: vbios: use checked access in `FwSecBiosImage::header` Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 07/22] gpu: nova-core: vbios: use checked accesses in `setup_falcon_data` Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 08/22] gpu: nova-core: vbios: drop unused falcon_data_offset from FwSecBiosBuilder Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 09/22] gpu: nova-core: vbios: keep PmuLookupTable local in setup_falcon_data Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 10/22] gpu: nova-core: vbios: compute FWSEC-relative Falcon data offset Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 11/22] gpu: nova-core: vbios: simplify setup_falcon_data Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 12/22] gpu: nova-core: vbios: read PMU lookup entries using FromBytes Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 13/22] gpu: nova-core: vbios: store PMU lookup entries in a KVVec Eliot Courtney
2026-05-25 14:29 ` Danilo Krummrich
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 14/22] gpu: nova-core: vbios: construct `FwSecBiosImage` directly from BIOS images Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 15/22] gpu: nova-core: vbios: use the first PCI-AT image Eliot Courtney
2026-05-25 14:46 ` Danilo Krummrich
2026-05-25 18:02 ` Miguel Ojeda
2026-05-25 18:08 ` Danilo Krummrich
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 16/22] gpu: nova-core: vbios: use single logical block for the FWSEC section Eliot Courtney
2026-05-25 21:03 ` Claude Code Review Bot [this message]
2026-05-25 13:57 ` [PATCH v5 17/22] gpu: nova-core: vbios: use let-else in Vbios::new Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 18/22] gpu: nova-core: vbios: remove unnecessary fields in PciRomHeader Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 19/22] gpu: nova-core: vbios: drop unused image wrappers Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 20/22] gpu: nova-core: vbios: drop redundant TryFrom import Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 21/22] gpu: nova-core: vbios: move constants and functions to be associated Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 13:57 ` [PATCH v5 22/22] gpu: nova-core: vbios: remove unused rom_header field Eliot Courtney
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
2026-05-25 18:35 ` [PATCH v5 00/22] gpu: nova-core: vbios: harden various array accesses and refactor Danilo Krummrich
2026-05-25 18:37 ` Danilo Krummrich
2026-05-25 21:03 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch16-20260525-fix-vbios-v5-16-e5e455251537@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox