From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Split AS SDP computation between compute_config and compute_config_late Date: Thu, 12 Mar 2026 06:55:31 +1000 Message-ID: In-Reply-To: <20260311113611.3393194-18-ankit.k.nautiyal@intel.com> References: <20260311113611.3393194-1-ankit.k.nautiyal@intel.com> <20260311113611.3393194-18-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Splits AS SDP programming into early (just the enable bit) and late (all fields) phases. The rationale is well explained in the commit message: the guardband calculation needs the enable bit early, but the actual SDP fields depend on features computed later. **Observation:** The `intel_dp_sdp_compute_config_late()` signature changes to accept `intel_dp`, which is a reasonable change. The approach is sound architecturally. --- Generated by Claude Code Patch Reviewer