public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: analogix_dp: Apply panel_bridge helper
Date: Sun, 22 Mar 2026 04:35:49 +1000	[thread overview]
Message-ID: <review-patch17-20260319074744.1965918-4-damon.ding@rock-chips.com> (raw)
In-Reply-To: <20260319074744.1965918-4-damon.ding@rock-chips.com>

Patch Review

Converts the panel to a panel_bridge, eliminating all direct `drm_panel_*` calls from the analogix_dp core. This is the final cleanup.

**BUG**: In the error path for `devm_drm_panel_bridge_add()`:
```c
dp->plat_data->next_bridge = devm_drm_panel_bridge_add(dp->dev,
                                                         dp->plat_data->panel);
if (IS_ERR(dp->plat_data->next_bridge)) {
    ret = PTR_ERR(bridge);    // <-- BUG: should be PTR_ERR(dp->plat_data->next_bridge)
    goto err_unregister_aux;
}
```
`bridge` is `&dp->bridge` which is a valid pointer at this point, so `PTR_ERR(bridge)` will return a garbage/wrong error code. This should be `PTR_ERR(dp->plat_data->next_bridge)`.

**Note on mbox ordering**: Patches 14-17 were sent as a separate sub-thread (different Message-Id base `20260319074744.1965918`), likely a resend to fix something. The logical ordering in the cover letter is respected but the mbox has some patches arriving out of numerical order (e.g., 10 before 08, 13 before 09). This is cosmetic but may confuse tooling.

---

**Summary**: The series is well-structured and mostly correct. The one real bug is the `PTR_ERR(bridge)` vs `PTR_ERR(dp->plat_data->next_bridge)` in patch 17 which must be fixed before merging.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-21 18:35 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19  7:14 [PATCH v11 00/17] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Damon Ding
2026-03-19  7:14 ` [PATCH v11 01/17] drm/bridge: analogix_dp: Add &analogix_dp_plat_data.next_bridge Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 02/17] drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 03/17] drm/exynos: exynos_dp: Remove &exynos_dp_device.ptn_bridge Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 04/17] drm/exynos: exynos_dp: Remove unused &exynos_dp_device.connector Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 05/17] drm/exynos: exynos_dp: Apply of-display-mode-bridge to parse the display-timings node Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 06/17] drm/bridge: analogix_dp: Remove redundant &analogix_dp_plat_data.skip_connector Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 07/17] drm/bridge: analogix_dp: Move the color format check to .atomic_check() for Rockchip platforms Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 08/17] drm/bridge: analogix_dp: Remove unused &analogix_dp_plat_data.get_modes() Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 09/17] drm/bridge: analogix_dp: Remove unused struct drm_connector* for &analogix_dp_plat_data.attach() Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 10/17] drm/bridge: analogix_dp: Pass struct drm_atomic_state* for analogix_dp_bridge_mode_set() Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 11/17] drm/bridge: analogix_dp: Apply drm_bridge_connector helper Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 12/17] drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe() Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 13/17] drm/rockchip: analogix_dp: Apply analogix_dp_finish_probe() Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:47 ` [PATCH v11 14/17] drm/exynos: exynos_dp: " Damon Ding
2026-03-19  7:47   ` [PATCH v11 15/17] drm/bridge: analogix_dp: Attach the next bridge in analogix_dp_bridge_attach() Damon Ding
2026-03-21 18:35     ` Claude review: " Claude Code Review Bot
2026-03-19  7:47   ` [PATCH v11 16/17] drm/bridge: analogix_dp: Remove bridge disabing and panel unpreparing in analogix_dp_unbind() Damon Ding
2026-03-21 18:35     ` Claude review: " Claude Code Review Bot
2026-03-19  7:47   ` [PATCH v11 17/17] drm/bridge: analogix_dp: Apply panel_bridge helper Damon Ding
2026-03-21 18:35     ` Claude Code Review Bot [this message]
2026-03-21 18:35   ` Claude review: drm/exynos: exynos_dp: Apply analogix_dp_finish_probe() Claude Code Review Bot
2026-03-21 18:35 ` Claude review: Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-02-10  7:12 [PATCH v9 00/15] " Damon Ding
2026-02-10  9:10 ` [PATCH v9 15/15] drm/bridge: analogix_dp: Apply panel_bridge helper Damon Ding
2026-02-11  6:37   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch17-20260319074744.1965918-4-damon.ding@rock-chips.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox